Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Config logger #8087

Closed
wants to merge 254 commits into from
Closed

Unified Config logger #8087

wants to merge 254 commits into from

Conversation

byawitz
Copy link
Member

@byawitz byawitz commented May 7, 2024

What does this PR do?

(Provide a description of what this PR does and why it's needed.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

LauraDuRy and others added 30 commits October 30, 2023 11:13
Updated twitter to X
Co-authored-by: Steven Nguyen <1477010+stnguyen90@users.noreply.github.com>
Bump executor version to fix docker conflict error
Every worker requires the DB env vars because a connection is created on init.
Fallback to using _APP_SMS_FROM for backwards compatibility.
It's done automatically when setting the params already.
Execution via domain should be blocked if permissions does not contain
any and permissions does not contain guests.
…ns-1.5.x

Fix functions domain permissions 1.5.x
Without this, PHP will try to look for an Exception class in the
Appwrite\Platform\Tasks namespace, which doesn't exist.
Update SDKs to fix incorrect MSG91 param
app/init.php Outdated Show resolved Hide resolved
Copy link
Member

@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also change the target branch to 1.6.x

@byawitz byawitz changed the base branch from main to 1.6.x May 20, 2024 18:07
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa there are a bit too many commits in this PR. maybe something else needs to be merged first...or some commits need to be removed 😬

@byawitz
Copy link
Member Author

byawitz commented May 23, 2024

@stnguyen90 here's a concise version of it #8187

@byawitz byawitz closed this May 23, 2024
@byawitz byawitz deleted the feat-unifying-app-logger-config branch May 23, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet